[frontend] Update demographic stixCoreRelationships from entity overview

[marieflorescontact]

Proposed changes

• Update of Citizenship / Nationality / Country of residence can be done directly from the overview tab. (alignment with others StixCoreRelationships)
• Apply review remarks on AddPersonaThreatActorIndividual and AddIndividualsThreatActorIndividual and childs components :
  • use usePreloadedQuery instead of useLazyLoadQuery,
  • use useFragment instead of useRefetchableFragment + remove useEffect()

Related issues

• closes Inconsistent behavior on overview of demographics #8343

Checklist

• I consider the submitted work as finished
• I tested the code for its functionality
• I wrote test cases for the relevant uses case (coverage and e2e)
• I added/update the relevant documentation (either on github or on notion)
• Where necessary I refactored code to improve the overall quality

Further comments

othe

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.28%. Comparing base (5266681) to head (3b6d100).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9637      +/-   ##
==========================================
+ Coverage   64.27%   64.28%   +0.01%     
==========================================
  Files         655      655              
  Lines       62935    62935              
  Branches     6960     6967       +7     
==========================================
+ Hits        40453    40460       +7     
+ Misses      22482    22475       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lndrtrbn]

Functionally seems good

[marieflorescontact]

PR status: all comments have been taken into account, ready for a second round of reviews

[Archidoit]

Can you modify the space before '-' in case of empty citizenship / country of residence / nationality ?

The space is too big compared to 'date of birth' for instance

See 'labels' for model

[Archidoit]

Can you add the possibility to also easily remove an added relationship

like it is the case located-at for instance

[Archidoit]

When adding/removing a citizenship, it is also add/removed in the country of residence, and same for the other way round

[Archidoit]

In the 'add citizenship' panel, the search bar is not working :

[Archidoit]

When creating a country from this panel (see 'create country' button), the country is created but the list is not updated

Maybe consider displaying the list of countries in a data table here, like it is done in other relationships creation form? (only a suggestion, don't know if it will help solving the search bar issue etc) , exemple:

[marieflorescontact]

Can you modify the space before '-' in case of empty citizenship / country of residence / nationality ? ![image](https://private-
The space is too big compared to 'date of birth' for instance

Fix => I've created a component to avoid multiple margin issue between labels and value

[marieflorescontact]

Can you add the possibility to also easily remove an added relationship ![image](https://private-user-
like it is the case located-at for instance ![image](https://private-user-images.githubusercontent.com/75783086/409479210-

Good idea but it needs to be discussed with product

[marieflorescontact]

PR status:
all the comments have been taken into account. except for the use of datatables and the addition of the ‘quick delete relationship’, which are outside the scope of the bug fix.
there is still some duplicated code but I've already spent a lot of time on this task so it'll come later. 😅:

<AddIndividualsThreatActorIndividualLines>
<AddPersonasThreatActorIndividualLines>
<AddThreatActorIndividualDemographicLines>