Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] put the auth member admin panel under EE (#4961) #9661

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

labo-flg
Copy link
Member

Proposed changes

Authorized members (a.k.a access restrictions) are a feature under Entreprise Edition.
As such, the admin panel for these entities should also be under EE.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@labo-flg labo-flg added the filigran team use to identify PR from the Filigran team label Jan 21, 2025
@CelineSebe CelineSebe self-requested a review January 21, 2025 16:53
@CelineSebe
Copy link
Member

CelineSebe commented Jan 22, 2025

tested ✅ (front-end)

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.36%. Comparing base (a17e41c) to head (7f1bfad).
Report is 2 commits behind head on release/6.5.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.5.0    #9661      +/-   ##
=================================================
- Coverage          64.36%   64.36%   -0.01%     
=================================================
  Files                645      645              
  Lines              62149    62149              
  Branches            6892     6894       +2     
=================================================
- Hits               40005    40000       -5     
- Misses             22144    22149       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact force-pushed the issue/4961-auth-member-under-ee branch from 13bade4 to 3649fa9 Compare January 22, 2025 14:19
@SouadHadjiat SouadHadjiat merged commit d93cdcf into release/6.5.0 Jan 22, 2025
5 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/4961-auth-member-under-ee branch January 22, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants