Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Improve application stopping time (#9740) #9715

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Jan 24, 2025

Proposed changes

  • enforce eslint "no floating promise" rule (backend only)
  • fix all floating promises on existing code (backend only)

Note: api-test are passing locally (with 01|02) which is not the case on current master so I think it's solving part of end of tests issues, probably proiduction issues too.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 24, 2025
@aHenryJard aHenryJard force-pushed the oob/stop-lag-investigation branch 2 times, most recently from cb2dfd3 to 27a7f9e Compare January 24, 2025 17:40
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 57.62712% with 25 lines in your changes missing coverage. Please review.

Project coverage is 64.29%. Comparing base (d695e99) to head (292a884).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...tform/opencti-graphql/src/graphql/sseMiddleware.js 0.00% 3 Missing ⚠️
...ti-platform/opencti-graphql/src/http/httpServer.js 0.00% 3 Missing ⚠️
...i-platform/opencti-graphql/src/config/providers.js 0.00% 2 Missing ⚠️
...platform/opencti-graphql/src/database/migration.js 0.00% 2 Missing ⚠️
...i-platform/opencti-graphql/src/database/session.js 0.00% 2 Missing ⚠️
...opencti-graphql/src/database/sessionStore-redis.js 33.33% 2 Missing ⚠️
...ti-platform/opencti-graphql/src/instrumentation.js 0.00% 2 Missing ⚠️
...orm/opencti-graphql/src/lock/child-lock.manager.ts 0.00% 2 Missing ⚠️
...rm/opencti-graphql/src/manager/ingestionManager.ts 0.00% 2 Missing ⚠️
opencti-platform/opencti-graphql/src/back.js 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9715      +/-   ##
==========================================
- Coverage   64.29%   64.29%   -0.01%     
==========================================
  Files         655      655              
  Lines       62938    62941       +3     
  Branches     6969     6967       -2     
==========================================
- Hits        40469    40468       -1     
- Misses      22469    22473       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard changed the title Doing some investigation on startup/stop [backend] Improve application stopping time (#9740) Jan 28, 2025
@aHenryJard aHenryJard force-pushed the oob/stop-lag-investigation branch from 27a7f9e to 4b59b35 Compare January 28, 2025 15:29
@aHenryJard aHenryJard marked this pull request as ready for review January 29, 2025 17:05
@richard-julien
Copy link
Member

Except my command, im ok with the concept.

@aHenryJard aHenryJard marked this pull request as draft February 4, 2025 09:56
@aHenryJard aHenryJard force-pushed the oob/stop-lag-investigation branch from d47d4eb to 62b1d70 Compare February 5, 2025 16:36
@aHenryJard aHenryJard marked this pull request as ready for review February 5, 2025 17:01
@aHenryJard aHenryJard force-pushed the oob/stop-lag-investigation branch from 62b1d70 to 6cf5c62 Compare February 7, 2025 07:57
@aHenryJard aHenryJard force-pushed the oob/stop-lag-investigation branch from bd08717 to 1234b04 Compare February 7, 2025 10:48
@aHenryJard aHenryJard merged commit 195f841 into master Feb 7, 2025
9 checks passed
@aHenryJard aHenryJard deleted the oob/stop-lag-investigation branch February 7, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve application stopping time
3 participants