Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix Fintel templates pdf export button (#8336) #9729

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Archidoit
Copy link
Member

Proposed changes

In content tab of a container, when we want to export an html fintel template in pdf, the ‘generate a pdf export’ redirects to the general export pop-up instead of the pre-built one (with 'html to pdf' connector by default)

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Jan 27, 2025
@Archidoit Archidoit self-assigned this Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.31%. Comparing base (dbda0cf) to head (a7cbf86).
Report is 4 commits behind head on release/6.5.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.5.0    #9729      +/-   ##
=================================================
+ Coverage          64.29%   64.31%   +0.01%     
=================================================
  Files                653      653              
  Lines              62460    62460              
  Branches            6921     6929       +8     
=================================================
+ Hits               40159    40171      +12     
+ Misses             22301    22289      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit merged commit 1532311 into release/6.5.0 Jan 28, 2025
5 checks passed
@Archidoit Archidoit deleted the issue/8336-fix-pdf branch January 28, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants