Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] dissemination list fix audit log on disseminate (#5551) #9784

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Jan 31, 2025

Proposed changes

  • Move activity log out of background task to get it work (requires a connected user).

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@frapuks frapuks self-requested a review January 31, 2025 10:18
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 64.23%. Comparing base (e6105f4) to head (d35c9fa).
Report is 2 commits behind head on release/6.5.0.

Files with missing lines Patch % Lines
...ules/disseminationList/disseminationList-domain.ts 4.76% 20 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           release/6.5.0    #9784   +/-   ##
==============================================
  Coverage          64.23%   64.23%           
==============================================
  Files                655      655           
  Lines              62813    62813           
  Branches            6956     6959    +3     
==============================================
  Hits               40351    40351           
  Misses             22462    22462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard merged commit 6362369 into release/6.5.0 Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants