Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Fintel templates improvements for 6.5 (#8336) #9789

Merged
merged 15 commits into from
Feb 3, 2025

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Jan 31, 2025

Proposed changes

Fintel templates improvements

  • some renamings
  • add a tooltip next to a filter with vaule 'current entity'
  • not possible to create attribute widget anymore
  • add 3 list widgets by default at a template creation
  • fix warning message design when deleting a widget that is used in the content
  • add date to files names generated from template in export form

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Jan 31, 2025
@Archidoit Archidoit self-assigned this Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 92.92929% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.51%. Comparing base (e6105f4) to head (a53e932).
Report is 4 commits behind head on release/6.5.0.

Files with missing lines Patch % Lines
...tils/fintelTemplate/__executiveSummary.template.ts 0.00% 6 Missing ⚠️
...rc/modules/fintelTemplate/fintelTemplate-domain.ts 97.72% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.5.0    #9789      +/-   ##
=================================================
+ Coverage          64.23%   64.51%   +0.27%     
=================================================
  Files                655      655              
  Lines              62813    62977     +164     
  Branches            6956     7070     +114     
=================================================
+ Hits               40351    40631     +280     
+ Misses             22462    22346     -116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

marieflorescontact

This comment was marked as resolved.

@Archidoit Archidoit linked an issue Feb 3, 2025 that may be closed by this pull request
@Archidoit
Copy link
Member Author

If I import a template , wich already has the 3 "by default widget", it adds again the 3 "by default widget" image

fixed :)

@Gwendoline-FAVRE-FELIX
Copy link
Member

Gwendoline-FAVRE-FELIX commented Feb 3, 2025

Is it deliberate to use publishUserAction for modify and delete but not for addFintelTemplate?

@Gwendoline-FAVRE-FELIX it's fixed! no it was not normal indeed :)

Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionaly tested ok 👌

@Archidoit Archidoit merged commit 8736c35 into release/6.5.0 Feb 3, 2025
2 of 3 checks passed
@Archidoit Archidoit deleted the issue/8336-fix2 branch February 3, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad entity type typo in Customization
4 participants