Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] migrate/refactor StixCoreObjectKnowledgeBar component #9817

Merged
merged 7 commits into from
Feb 6, 2025

Conversation

delemaf
Copy link
Member

@delemaf delemaf commented Feb 4, 2025

Proposed changes

  • Migrate StixCoreObjectKnowledgeBar (you can test in Arsenal, Entities, Events, Locations, Techinques & Threats)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@delemaf delemaf self-assigned this Feb 4, 2025
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.28%. Comparing base (1442c72) to head (caab632).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9817      +/-   ##
==========================================
- Coverage   64.29%   64.28%   -0.02%     
==========================================
  Files         655      655              
  Lines       62909    62909              
  Branches     6966     6962       -4     
==========================================
- Hits        40450    40443       -7     
- Misses      22459    22466       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delemaf delemaf changed the title [frontend] migrate StixCoreObjectKnowledgeBar component [frontend] migrate/refactor StixCoreObjectKnowledgeBar component Feb 5, 2025
@CelineSebe
Copy link
Member

CelineSebe commented Feb 5, 2025

I'm not sure if this problem is linked to this PR, but I didn't encounter it on testing or prerelease, so it might be related. As you see below, there's a large space on the left side of the knowledge bar :
image

The knowledge bar also is narrower in comparison with testing. The problem must be due to that.
Is this expected?
image

to={`${stixCoreObjectLink}/${path}`}
iconType={iconType}
label={label}
count={count}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to update the counts for each item without refreshing the page easily? (with a refetch or a state)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, the cause is probably the buggy relay query in the Root components and the way the subscription is done, even the counter of the table is not refreshed, it's not due to the refactor of this component. But I'll open a issue to handle this bug 🙏

@delemaf delemaf force-pushed the oob/migrate-knowledge-bar branch from a4a4e8a to 42d4e08 Compare February 5, 2025 16:51
@delemaf delemaf merged commit af2ab56 into master Feb 6, 2025
9 checks passed
@SamuelHassine SamuelHassine deleted the oob/migrate-knowledge-bar branch February 6, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants