-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] migrate/refactor StixCoreObjectKnowledgeBar component #9817
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9817 +/- ##
==========================================
- Coverage 64.29% 64.28% -0.02%
==========================================
Files 655 655
Lines 62909 62909
Branches 6966 6962 -4
==========================================
- Hits 40450 40443 -7
- Misses 22459 22466 +7 ☔ View full report in Codecov by Sentry. |
to={`${stixCoreObjectLink}/${path}`} | ||
iconType={iconType} | ||
label={label} | ||
count={count} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to update the counts for each item without refreshing the page easily? (with a refetch or a state)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet, the cause is probably the buggy relay query in the Root components and the way the subscription is done, even the counter of the table is not refreshed, it's not due to the refactor of this component. But I'll open a issue to handle this bug 🙏
a4a4e8a
to
42d4e08
Compare
Proposed changes
Related issues
Checklist
Further comments