Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix enrich button (#9854) #9856

Merged
merged 3 commits into from
Feb 6, 2025
Merged

[frontend] fix enrich button (#9854) #9856

merged 3 commits into from
Feb 6, 2025

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Feb 6, 2025

Proposed changes

  • fix enrich drawer open condition
  • add e2e coverage

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Feb 6, 2025
@JeremyCloarec JeremyCloarec linked an issue Feb 6, 2025 that may be closed by this pull request
@JeremyCloarec JeremyCloarec marked this pull request as ready for review February 6, 2025 15:10
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.29%. Comparing base (af2ab56) to head (5c2db80).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9856   +/-   ##
=======================================
  Coverage   64.29%   64.29%           
=======================================
  Files         655      655           
  Lines       62909    62909           
  Branches     6966     6969    +3     
=======================================
  Hits        40450    40450           
  Misses      22459    22459           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg self-requested a review February 6, 2025 15:51
@JeremyCloarec JeremyCloarec merged commit c28015c into master Feb 6, 2025
9 checks passed
@JeremyCloarec JeremyCloarec deleted the issue/9854 branch February 6, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enrich button doesn't work
2 participants