Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix malware variants missing from relationships (#9531) #9870

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

delemaf
Copy link
Member

@delemaf delemaf commented Feb 7, 2025

Proposed changes

  • In Arsenal > Malwares > Knowledge > Variants fix relationships view allowing allDirections
  • Handle relationship icon change when relation is from or to entity
    image

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@delemaf delemaf self-assigned this Feb 7, 2025
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Feb 7, 2025
@CelineSebe
Copy link
Member

Tested 👌

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.30%. Comparing base (d695e99) to head (8bc66a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9870   +/-   ##
=======================================
  Coverage   64.29%   64.30%           
=======================================
  Files         655      655           
  Lines       62938    62938           
  Branches     6969     6975    +6     
=======================================
+ Hits        40469    40471    +2     
+ Misses      22469    22467    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delemaf delemaf merged commit 78b02b8 into master Feb 7, 2025
9 checks passed
@CelineSebe CelineSebe deleted the issue/9531 branch February 10, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linked entity and relationship lists inconsistent in knowledge tab
2 participants