Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Add markings support for workbench #9883

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Conversation

richard-julien
Copy link
Member

[client] Add markings support for workbench

@richard-julien richard-julien self-assigned this Feb 8, 2025
@richard-julien richard-julien linked an issue Feb 8, 2025 that may be closed by this pull request
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.43%. Comparing base (85f6fa2) to head (349aa0a).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
...encti-platform/opencti-graphql/src/utils/access.ts 72.72% 3 Missing ⚠️
...pencti-platform/opencti-graphql/src/domain/file.js 33.33% 2 Missing ⚠️
...tform/opencti-graphql/src/database/file-storage.js 83.33% 1 Missing ⚠️
...cti-platform/opencti-graphql/src/resolvers/file.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9883      +/-   ##
==========================================
+ Coverage   64.29%   64.43%   +0.14%     
==========================================
  Files         655      655              
  Lines       62933    62983      +50     
  Branches     6964     7131     +167     
==========================================
+ Hits        40460    40581     +121     
+ Misses      22473    22402      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat self-requested a review February 10, 2025 08:33
@SouadHadjiat
Copy link
Member

When I create a workbench with a specific marking, it's well created with the marking, but then if I click on the workbench, and come back to the list view, the marking disapears (it's because when we click on the workbench, it sends a mutation that uploads again the workbench file, without markings)
image
image

@richard-julien
Copy link
Member Author

When I create a workbench with a specific marking, it's well created with the marking, but then if I click on the workbench, and come back to the list view, the marking disapears (it's because when we click on the workbench, it sends a mutation that uploads again the workbench file, without markings)

Nice catch @SouadHadjiat thanks. Fixed in the last commit

@SouadHadjiat
Copy link
Member

@richard-julien richard-julien merged commit 7c7d6b1 into master Feb 13, 2025
9 checks passed
@richard-julien richard-julien deleted the issue/9882 branch February 13, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add markings support for workbench
2 participants