Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Align the height between EnterpriseEdition and Danger zone labels #9998

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Feb 18, 2025

Proposed changes

  • change the EEchip height

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Feb 18, 2025
@CelineSebe CelineSebe changed the title [frontend] Align the height of hints [frontend] Align the height between EnterpriseEdition and Danger zone labels Feb 18, 2025
@CelineSebe CelineSebe self-assigned this Feb 18, 2025
@CelineSebe CelineSebe linked an issue Feb 18, 2025 that may be closed by this pull request
@CelineSebe CelineSebe marked this pull request as ready for review February 18, 2025 09:57
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.33%. Comparing base (9658766) to head (2b0dba7).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9998      +/-   ##
==========================================
+ Coverage   64.31%   64.33%   +0.01%     
==========================================
  Files         656      656              
  Lines       63037    63037              
  Branches     6986     6994       +8     
==========================================
+ Hits        40544    40556      +12     
+ Misses      22493    22481      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe CelineSebe merged commit 274ab3a into master Feb 19, 2025
9 checks passed
@CelineSebe CelineSebe deleted the issue/9569 branch February 19, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align the height of hints to avoid strange effect on some windows
2 participants