Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn about org owners without team #79

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Do not warn about org owners without team #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions gh_org_mgr/_gh_org.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,8 +676,10 @@ def get_members_without_team(self) -> None:
for _, team_attrs in self.current_teams.items():
for member in team_attrs.get("members", {}):
all_team_members_lst.append(member)
# Also add users that have just been added to a team, and unify them
all_team_members: set[NamedUser] = set(all_team_members_lst + self.newly_added_users)
# Also add org owners and users that have just been added to a team, and unify them
all_team_members: set[NamedUser] = set(
all_team_members_lst + self.newly_added_users + self.current_org_owners
)

# Find members that are in org_members but not team_members
members_without_team = all_org_members.difference(all_team_members)
Expand Down