Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: add stubs (static) #60

Merged
merged 1 commit into from
Sep 23, 2024
Merged

python: add stubs (static) #60

merged 1 commit into from
Sep 23, 2024

Conversation

Tristramg
Copy link
Contributor

This has been generated by https://github.com/Jij-Inc/pyo3-stub-gen

However, there is a chain of dependencies that makes it hard to include the build process in this commit.

That is why we offer for now a static file (as suggested in https://pyo3.rs/v0.16.4/python_typing_hints.html)

@Tristramg Tristramg requested a review from Castavo September 19, 2024 13:39
@Tristramg Tristramg self-assigned this Sep 19, 2024
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat ! None of the Builder methods have any docstring, is that normal ?

@Tristramg
Copy link
Contributor Author

It’s normal from a technical point of view: there aren’t any in the rust source. I got lost trying to re-use things from the native builder. In the end, probably re-typing everything is the right way to do it, but that requires documenting them.

Let’s say that I’ll add that to this PR

@Tristramg
Copy link
Contributor Author

I've commented the whole builder

This has been generated by https://github.com/Jij-Inc/pyo3-stub-gen

However, there is a chain of dependencies that makes it hard to include the build process in this commit.

That is why we offer for now a static file (as suggested in https://pyo3.rs/v0.16.4/python_typing_hints.html)

Signed-off-by: Tristram Gräbener <[email protected]>
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super neat !

@Tristramg Tristramg merged commit 9172233 into main Sep 23, 2024
8 checks passed
@Tristramg Tristramg deleted the pyi_stubs_static branch December 1, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants