Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm + html demo: add click to measure functionality #79

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Oct 18, 2024

Wouhouuu

It worked on my machine, hope it does on yours

Maybe my handling of window.Alpine and of lrs is dirty, I don't really know...

Also, I opted for putting the PK in the sidebar fields, but we could very well go for a popup

Copy link
Contributor

@Tristramg Tristramg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it worked on mine, thank you.

There is a bug revelead by this (on long traversals, there is a drift), but this isn’t releated to this feature and no need to fix it before releasing it.

@Castavo Castavo requested a review from Tristramg October 21, 2024 11:53
@Castavo Castavo self-assigned this Oct 21, 2024
Copy link
Contributor

@Tristramg Tristramg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me! Just a squash and go!

@Tristramg Tristramg mentioned this pull request Oct 21, 2024
@Castavo Castavo merged commit a83b3d9 into main Oct 21, 2024
26 checks passed
@Tristramg Tristramg deleted the add-click-to-pk branch December 1, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants