Skip to content

Vcs/zoom rectangle 3 #2984

Vcs/zoom rectangle 3

Vcs/zoom rectangle 3 #2984

Triggered via pull request March 6, 2025 08:59
Status Failure
Total duration 1m 18s
Artifacts

osrd-ui-build.yml

on: pull_request
build
1m 9s
build
check_commits
5s
check_commits
Check final newline
12s
Check final newline
Check unit tests
26s
Check unit tests
Check REUSE Compliance
10s
Check REUSE Compliance
Check DCO
3s
Check DCO
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 10 warnings
Check DCO
Process completed with exit code 1.
src/manchette/useManchetteWithSpaceTimeChart/__tests__/helpers.spec.ts > computeWaypointsToDisplay > should return correct heights for proportional display: ui-charts/src/manchette/useManchetteWithSpaceTimeChart/__tests__/helpers.spec.ts#L58
AssertionError: expected 'NaNpx' to be '428px' // Object.is equality Expected: "428px" Received: "NaNpx" ❯ src/manchette/useManchetteWithSpaceTimeChart/__tests__/helpers.spec.ts:58:38
Check unit tests
Process completed with exit code 1.
build
Process completed with exit code 1.
build: ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L26
There should be at least one empty line between import groups
build: ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L27
There should be at least one empty line between import groups
build: ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L27
`lodash` import should occur before import of `./usePaths`
build: ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L28
`../utils` import should occur before import of `../utils/point`
build: ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L105
Replace `·computeWaypointsToDisplay(waypoints,·{·height,·isProportional,·yZoom·},·minZoomMillimetrePerPx,·maxZoomMillimetrePerPx` with `⏎······computeWaypointsToDisplay(⏎········waypoints,⏎········{·height,·isProportional,·yZoom·},⏎········minZoomMillimetrePerPx,⏎········maxZoomMillimetrePerPx⏎······`
build: ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L106
React Hook useMemo has missing dependencies: 'maxZoomMillimetrePerPx' and 'minZoomMillimetrePerPx'. Either include them or remove the dependency array
build: ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L121
Replace `·getScales(simplifiedWaypoints,·{·height,·isProportional,·yZoom·},·minZoomMillimetrePerPx,·maxZoomMillimetrePerPx` with `⏎······getScales(⏎········simplifiedWaypoints,⏎········{·height,·isProportional,·yZoom·},⏎········minZoomMillimetrePerPx,⏎········maxZoomMillimetrePerPx⏎······`
build: ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L122
React Hook useMemo has missing dependencies: 'maxZoomMillimetrePerPx' and 'minZoomMillimetrePerPx'. Either include them or remove the dependency array