Vcs/zoom rectangle 3 #2989
anisometropieosrd-ui-build.yml
on: pull_request
build
1m 20s
check_commits
5s
Check final newline
56s
Check unit tests
27s
Check REUSE Compliance
15s
Check DCO
3s
Annotations
4 errors and 10 warnings
|
Check DCO
Process completed with exit code 1.
|
|
src/manchette/useManchetteWithSpaceTimeChart/__tests__/helpers.spec.ts > computeWaypointsToDisplay > should return correct heights for proportional display:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/__tests__/helpers.spec.ts#L58
AssertionError: expected 'NaNpx' to be '428px' // Object.is equality
Expected: "428px"
Received: "NaNpx"
❯ src/manchette/useManchetteWithSpaceTimeChart/__tests__/helpers.spec.ts:58:38
|
|
Check unit tests
Process completed with exit code 1.
|
|
build
Process completed with exit code 1.
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L22
'zoomValueToSpaceScale' is defined but never used
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L27
There should be at least one empty line between import groups
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L28
There should be at least one empty line between import groups
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L28
`lodash` import should occur before import of `./usePaths`
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L29
`../utils` import should occur before import of `../utils/point`
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L115
Replace `·computeWaypointsToDisplay(waypoints,·{·height,·isProportional,·yZoom·},·minZoomMillimetrePerPx,·maxZoomMillimetrePerPx` with `⏎······computeWaypointsToDisplay(⏎········waypoints,⏎········{·height,·isProportional,·yZoom·},⏎········minZoomMillimetrePerPx,⏎········maxZoomMillimetrePerPx⏎······`
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L116
React Hook useMemo has missing dependencies: 'maxZoomMillimetrePerPx' and 'minZoomMillimetrePerPx'. Either include them or remove the dependency array
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L131
Replace `·getScales(simplifiedWaypoints,·{·height,·isProportional,·yZoom·},·minZoomMillimetrePerPx,·maxZoomMillimetrePerPx` with `⏎······getScales(⏎········simplifiedWaypoints,⏎········{·height,·isProportional,·yZoom·},⏎········minZoomMillimetrePerPx,⏎········maxZoomMillimetrePerPx⏎······`
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L132
React Hook useMemo has missing dependencies: 'maxZoomMillimetrePerPx' and 'minZoomMillimetrePerPx'. Either include them or remove the dependency array
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L137
Irregular whitespace not allowed
|