Vcs/zoom rectangle 3 #2992
anisometropieosrd-ui-build.yml
on: pull_request
build
1m 18s
check_commits
4s
Check final newline
11s
Check unit tests
32s
Check REUSE Compliance
8s
Check DCO
3s
Annotations
4 errors and 10 warnings
|
Check DCO
Process completed with exit code 1.
|
|
src/manchette/useManchetteWithSpaceTimeChart/__tests__/helpers.spec.ts > computeWaypointsToDisplay > should return correct heights for proportional display:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/__tests__/helpers.spec.ts#L58
AssertionError: expected 'NaNpx' to be '428px' // Object.is equality
Expected: "428px"
Received: "NaNpx"
❯ src/manchette/useManchetteWithSpaceTimeChart/__tests__/helpers.spec.ts:58:38
|
|
Check unit tests
Process completed with exit code 1.
|
|
build
Process completed with exit code 1.
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L123
React Hook useMemo has missing dependencies: 'maxZoomMillimetrePerPx' and 'minZoomMillimetrePerPx'. Either include them or remove the dependency array
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L145
React Hook useMemo has missing dependencies: 'maxZoomMillimetrePerPx' and 'minZoomMillimetrePerPx'. Either include them or remove the dependency array
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L148
Unexpected console statement
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L150
Irregular whitespace not allowed
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L153
Irregular whitespace not allowed
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L201
React Hook useCallback has missing dependencies: 'maxZoomMillimetrePerPx', 'minZoomMillimetrePerPx', 'yOffset', and 'yZoom'. Either include them or remove the dependency array
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L242
React Hook useEffect has missing dependencies: 'drawingHeightWithoutTopPadding', 'isProportional', 'pixelRect', 'rect', 'spaceTimeChartRef', 'yOffset', 'yZoom', and 'zoomMode'. Either include them or remove the dependency array
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L370
'height' is already declared in the upper scope on line 67 column 3
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L437
React Hook useMemo has missing dependencies: 'isProportional', 'rect', 'spaceOrigin', and 'timeOrigin'. Either include them or remove the dependency array
|
|
build:
ui-charts/src/manchette/useManchetteWithSpaceTimeChart/hooks/useManchetteWithSpaceTimeChart.ts#L453
Replace `()·=>·zoomValueToSpaceScale(minZoomMillimetrePerPx,·maxZoomMillimetrePerPx,·yZoom),·[yZoom,·minZoomMillimetrePerPx,·maxZoomMillimetrePerPx]` with `⏎····()·=>·zoomValueToSpaceScale(minZoomMillimetrePerPx,·maxZoomMillimetrePerPx,·yZoom),⏎····[yZoom,·minZoomMillimetrePerPx,·maxZoomMillimetrePerPx]⏎··`
|