Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space time chart not starting from origin #632

Open
SharglutDev opened this issue Oct 10, 2024 · 4 comments
Open

Space time chart not starting from origin #632

SharglutDev opened this issue Oct 10, 2024 · 4 comments

Comments

@SharglutDev
Copy link
Contributor

SharglutDev commented Oct 10, 2024

What happened?

With certain path, there can multiple waypoints at position 0 (i.e. Paris Nord - Lille Flandres).
When it does, the curve of the space time chart doesn't start from the first waypoint but the last at position 0.

Image

What did you expect to happen?

If some OP are overlapping, only the one asked by the user should be kept, and the GET should start from there. Same thing for STDCM (see comment below).

How can we reproduce it (as minimally and precisely as possible)?

  1. Add a Paris Nord - Lille Flandres train
  2. Check the space time cart

On which environments the bug occurs?

Deployed Storybook

On which browser the bug occurs?

Firefox

@axrolld
Copy link

axrolld commented Oct 11, 2024

Most likely the same thing happening on STDCM. I asked for a departure in Rennes RF here :
Image

@Synar Synar assigned Synar and unassigned Synar Jan 23, 2025
@jacomyal
Copy link
Contributor

Oh, I didn't know that there could be multiple waypoints with the exact same position. I'm not sure what is supposed to happen in these cases @thibautsailly.

Also, the current behavior will be impacted by PR #919, that handles SpaceTimeChart splits.

@thibautsailly
Copy link
Contributor

I'm not too sure how this should be dealt with and will ask users about it as quickly as possible.

@thibautsailly
Copy link
Contributor

Um, I'm sorry but a misclick while on the train closed this issue…

@thibautsailly thibautsailly reopened this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants