Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add closing X in date_picker, time_picker, and tolerance_picker #693

Closed
axrolld opened this issue Nov 5, 2024 · 0 comments · Fixed by #773 or #777
Closed

Add closing X in date_picker, time_picker, and tolerance_picker #693

axrolld opened this issue Nov 5, 2024 · 0 comments · Fixed by #773 or #777

Comments

@axrolld
Copy link

axrolld commented Nov 5, 2024

Image
Image

If https://github.com/osrd-project/osrd-confidential/issues/849 is being done at the same time:
Image

Otherwise:
Image

AC

  • when bumping the new release in osrd, don't forget to update the stdcm test to close the tolerance modal in stdcm-page-model.ts l.382
@axrolld axrolld changed the title Add closing X in date_picker, time_picker, and tolerance_picker, and simplify tolerancepicker Add closing X in date_picker, time_picker, and tolerance_picker Nov 5, 2024
@axrolld axrolld transferred this issue from OpenRailAssociation/osrd Nov 5, 2024
@SharglutDev SharglutDev self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants