ui-core: add close button to pickers #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yohh
reviewed
Dec 19, 2024
SharglutDev
force-pushed
the
ui-core/pickers/add-close-button
branch
from
4a6b302 to
1137bab
Compare
kmer2016
reviewed
Dec 19, 2024
kmer2016
approved these changes
Dec 19, 2024
Yohh
approved these changes
Dec 19, 2024
- use the Modal component to display the calendar picker to harmonize with tolerance and time picker - add a modal.css file with the modal base styles to avoid repeating the code - add a close button to the Modal component Signed-off-by: SharglutDev <[email protected]>
SharglutDev
force-pushed
the
ui-core/pickers/add-close-button
branch
from
0207d6d to
96c51b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #693
Sketch with mockup on the date picker