Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check commit title action #109

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Add check commit title action #109

merged 1 commit into from
Jul 10, 2024

Conversation

flomonster
Copy link
Contributor

No description provided.

@flomonster flomonster requested a review from a team as a code owner July 10, 2024 08:05
@flomonster flomonster requested review from kmer2016, Yohh and bloussou July 10, 2024 08:05
younesschrifi
younesschrifi approved these changes Jul 10, 2024
View reviewed changes
Copy link

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Perhaps you could add an example commit in the error message if you think this is necessary ?

@bloussou bloussou changed the title Add check commit tittle action Add check commit title action Jul 10, 2024
@flomonster
Copy link
Contributor Author

LGTM. Perhaps you could add an example commit in the error message if you think this is necessary ?

I just copied the script from the osrd repository.

bloussou
bloussou approved these changes Jul 10, 2024
View reviewed changes
Copy link

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ✨

Yohh
Yohh approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@ElysaSrc ElysaSrc added this pull request to the merge queue Jul 10, 2024
Merged via the queue into dev with commit bd171cc Jul 10, 2024
2 checks passed
@ElysaSrc ElysaSrc deleted the fam/add-check-commit-title branch July 10, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yohh Yohh Yohh approved these changes

@bloussou bloussou bloussou approved these changes

@younesschrifi younesschrifi younesschrifi approved these changes

@kmer2016 kmer2016 Awaiting requested review from kmer2016

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flomonster @Yohh @bloussou @younesschrifi @ElysaSrc