Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-icons: add class and color in the icons props #168

Merged
merged 1 commit into from
Jul 22, 2024
Merged

ui-icons: add class and color in the icons props #168

merged 1 commit into from
Jul 22, 2024

Conversation

SarahBellaha
Copy link
Contributor

Closes #9

@SarahBellaha SarahBellaha requested a review from a team as a code owner July 10, 2024 09:21
@SarahBellaha SarahBellaha requested a review from Yohh July 10, 2024 09:27
@SarahBellaha SarahBellaha force-pushed the sba/ui-icons/update-icons-props-9 branch from 8642ea7 to 21be04d Compare July 10, 2024 11:17
Yohh
Yohh approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

SharglutDev
SharglutDev approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thank you !

@SharglutDev SharglutDev added this pull request to the merge queue Jul 22, 2024
Merged via the queue into dev with commit a7cf783 Jul 22, 2024
1 check passed
@SharglutDev SharglutDev deleted the sba/ui-icons/update-icons-props-9 branch July 22, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turnerian2004 turnerian2004 turnerian2004 left review comments

@Yohh Yohh Yohh approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI-icons: update the icon component to add classname props
4 participants
@SarahBellaha @Yohh @SharglutDev @turnerian2004