Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: copy osrd eslintrc rules #280

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Jul 29, 2024

  • update eslintrc
  • add global lint script in /package.json
  • add lint & lint:fix script in //p package.json
  • fix auto-fixables warnings/errors

close #279

@Yohh Yohh requested a review from a team as a code owner July 29, 2024 16:36
@Yohh Yohh marked this pull request as draft July 30, 2024 07:55
@Yohh Yohh marked this pull request as ready for review July 30, 2024 10:41
@Yohh Yohh force-pushed the yoh/setup-adapt-eslint-rules-to-osrd-rules branch 2 times, most recently from 9d4cb93 to 6fbb744 Compare July 30, 2024 12:23
@sim51
Copy link
Contributor

sim51 commented Jul 30, 2024

All good for me.
Great job !

@Yohh Yohh force-pushed the yoh/setup-adapt-eslint-rules-to-osrd-rules branch 2 times, most recently from 428b7b7 to b38b96a Compare July 30, 2024 13:39
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job !

@Yohh Yohh force-pushed the yoh/setup-adapt-eslint-rules-to-osrd-rules branch from 089ac35 to 6183492 Compare July 30, 2024 15:02
@Yohh Yohh force-pushed the yoh/setup-adapt-eslint-rules-to-osrd-rules branch from 9cb11b3 to d25f030 Compare July 30, 2024 15:06
@Yohh Yohh enabled auto-merge July 30, 2024 15:07
@Yohh Yohh added this pull request to the merge queue Jul 30, 2024
Merged via the queue into dev with commit 510ab71 Jul 30, 2024
3 checks passed
@Yohh Yohh deleted the yoh/setup-adapt-eslint-rules-to-osrd-rules branch July 30, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup: copy osrd eslintrc rules to osrd-ui
4 participants