Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-core: adding generic props on button #286

Merged
merged 1 commit into from
Jul 30, 2024
Merged

ui-core: adding generic props on button #286

merged 1 commit into from
Jul 30, 2024

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Jul 30, 2024

Fix #252

@sim51 sim51 requested a review from a team as a code owner July 30, 2024 13:44
@sim51 sim51 enabled auto-merge July 30, 2024 14:16
@sim51 sim51 requested a review from kmer2016 July 30, 2024 14:18
kmer2016
kmer2016 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested !

@sim51 sim51 added this pull request to the merge queue Jul 30, 2024
Merged via the queue into dev with commit 77f1bd1 Jul 30, 2024
3 checks passed
@sim51 sim51 deleted the bsi/issue-252 branch July 30, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmer2016 kmer2016 kmer2016 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI-CORE] Allow to pass a classname to Button
2 participants
@sim51 @kmer2016