Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-speedspacechart: fix pr names display #290

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Jul 31, 2024

close #289

@Yohh Yohh force-pushed the yoh/ui-speedspacechart-fix-pr-names-display branch 3 times, most recently from 3101b33 to 3006312 Compare August 1, 2024 14:03
@Yohh Yohh marked this pull request as ready for review August 1, 2024 14:06
@Yohh Yohh requested a review from a team as a code owner August 1, 2024 14:06
@Yohh Yohh requested review from Math-R and Uriel-Sautron August 1, 2024 14:09
@Math-R Math-R enabled auto-merge August 1, 2024 15:54
@Math-R Math-R disabled auto-merge August 1, 2024 15:54
@Math-R
Copy link
Contributor

Math-R commented Aug 1, 2024

Sorry miss navigation and fail click, need to review....

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rendering, thank you !!! Tested.
Just a few comments.

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm & tested

Yohh added 2 commits August 2, 2024 16:05
- display pr's ticks, lines and texts only if they have 16px free
- adapt snaping to new pr's display and fix reticle to eco curve
@Yohh Yohh force-pushed the yoh/ui-speedspacechart-fix-pr-names-display branch from af4c8d2 to 3840593 Compare August 2, 2024 14:05
@Yohh Yohh enabled auto-merge August 2, 2024 14:06
@Yohh Yohh added this pull request to the merge queue Aug 2, 2024
Merged via the queue into dev with commit 362d054 Aug 2, 2024
4 checks passed
@Yohh Yohh deleted the yoh/ui-speedspacechart-fix-pr-names-display branch August 2, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui-speedspacechart: fix pr's names display
3 participants