Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-manchette: highlight selected train #293

Merged
merged 1 commit into from
Aug 1, 2024
Merged

ui-manchette: highlight selected train #293

merged 1 commit into from
Aug 1, 2024

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Jul 31, 2024 •
edited
Loading

  • Now the component also use the real name of trains

close #268
close #292

@Math-R Math-R requested a review from a team as a code owner July 31, 2024 15:04
@Math-R Math-R assigned Math-R, Yohh, clarani and Caracol3 and unassigned Math-R Jul 31, 2024
@Math-R Math-R mentioned this pull request Jul 31, 2024
Closed
1 task
clarani
clarani approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@clarani clarani removed their assignment Aug 1, 2024
@Math-R Math-R enabled auto-merge August 1, 2024 12:07
@Math-R Math-R disabled auto-merge August 1, 2024 12:07
@Math-R Math-R requested a review from clarani August 1, 2024 12:53
clarani
clarani approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Math-R Math-R force-pushed the mrd/highlight-selected-train branch from e34af20 to be7a9f8 Compare August 1, 2024 13:24
Yohh
Yohh approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@Math-R Math-R enabled auto-merge August 1, 2024 13:30
@Math-R Math-R force-pushed the mrd/highlight-selected-train branch from be7a9f8 to 9b4751c Compare August 1, 2024 15:53
@Math-R Math-R force-pushed the mrd/highlight-selected-train branch from 9b4751c to 4f2b1e3 Compare August 1, 2024 16:12
@Math-R Math-R added this pull request to the merge queue Aug 1, 2024
Merged via the queue into dev with commit 792d092 Aug 1, 2024
4 checks passed
@Math-R Math-R deleted the mrd/highlight-selected-train branch August 1, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yohh Yohh Yohh approved these changes

@clarani clarani clarani approved these changes

Assignees

@Yohh Yohh

@Caracol3 Caracol3

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Math-R @Yohh @clarani @Caracol3