Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-core, input : fix focus input by using tab keyboard #35

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Apr 17, 2024

closes #34
Before this pull request, in the Docs section of the Storybook for the Input component, when trying to focus on an input using the Tab key, all inputs were mistakenly getting focused at the same time.

@kmer2016 kmer2016 requested a review from Math-R April 17, 2024 10:07
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmer2016 kmer2016 merged commit 79d9f52 into dev Apr 18, 2024
1 check passed
@kmer2016 kmer2016 deleted the cnh/ui-core-fix-focus branch April 18, 2024 06:42
@kmer2016 kmer2016 mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui-core: Input Focus Issue
2 participants