Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osrd-ui: speedspacechart: setup speedspacechart #36

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Apr 17, 2024

No description provided.

@Yohh Yohh force-pushed the yoh/ui-speedspacechart-setup-rebased branch 4 times, most recently from a671b57 to 0eb0d56 Compare April 22, 2024 20:04
@Yohh Yohh marked this pull request as draft April 23, 2024 09:06
@Yohh Yohh force-pushed the yoh/ui-speedspacechart-setup-rebased branch 6 times, most recently from f7103be to f3a48c2 Compare April 26, 2024 13:18
@Yohh Yohh force-pushed the yoh/ui-speedspacechart-setup-rebased branch 3 times, most recently from ac74e81 to e4e6555 Compare May 17, 2024 10:00
@Yohh Yohh force-pushed the yoh/ui-speedspacechart-setup-rebased branch 8 times, most recently from 10dfff2 to 14f2ad4 Compare May 31, 2024 09:32
@Yohh Yohh force-pushed the yoh/ui-speedspacechart-setup-rebased branch from fd8716e to 6a0fb47 Compare June 4, 2024 08:03
@Yohh Yohh marked this pull request as ready for review June 4, 2024 12:33
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! I've left a few comments. Otherwise, I think the Layer slicing strategy is very good ! Increase the maintenability and the testability.

@Yohh Yohh force-pushed the yoh/ui-speedspacechart-setup-rebased branch 2 times, most recently from 23335eb to 6016e1d Compare June 5, 2024 10:04
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the typo EOF. Also, please consider the comments from the others.

@Yohh Yohh requested a review from anisometropie June 6, 2024 08:29
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, really Well done overall, I really like that each part of the graph has its own seperate canvas and logic, which make for a really clean and maintainable code

@Yohh Yohh force-pushed the yoh/ui-speedspacechart-setup-rebased branch 2 times, most recently from 672a042 to 64929ac Compare June 6, 2024 09:35
- synchronize speedspacechart project with npm deployment specifications
- add a readMe file
- create SpeedSpaceChart main component
- add a story for storyBook using sampleData.ts
- create useCanvas custom hook in hooks.ts
- create layers in components/layers/
- create /components/helpers/ with drawElements/ containing draw functions files, one for each king of element
- create layersManager for interactive functions as zoom and reset
- add X axis zoom
- create details box following the reticle
- add snapping to closest pr
- extract tain details box from reticle draw function to his own component
- adapt vertical lines to PRs position
- add PRs names
- add tests for utils functions
@Yohh Yohh force-pushed the yoh/ui-speedspacechart-setup-rebased branch from 64929ac to ce92e48 Compare June 6, 2024 09:39
@kmer2016 kmer2016 merged commit 3f43b61 into dev Jun 6, 2024
1 check passed
@kmer2016 kmer2016 deleted the yoh/ui-speedspacechart-setup-rebased branch June 6, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants