-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osrd-ui: speedspacechart: setup speedspacechart #36
Conversation
a671b57
to
0eb0d56
Compare
f7103be
to
f3a48c2
Compare
ac74e81
to
e4e6555
Compare
10dfff2
to
14f2ad4
Compare
fd8716e
to
6a0fb47
Compare
ui-speedspacechart/src/components/helpers/drawElements/curve.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/curve.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/curve.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/gridX.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/gridY.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! I've left a few comments. Otherwise, I think the Layer slicing strategy is very good ! Increase the maintenability and the testability.
ui-speedspacechart/src/components/helpers/drawElements/reticle.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/reticle.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/reticle.ts
Outdated
Show resolved
Hide resolved
23335eb
to
6016e1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the typo EOF. Also, please consider the comments from the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, really Well done overall, I really like that each part of the graph has its own seperate canvas and logic, which make for a really clean and maintainable code
672a042
to
64929ac
Compare
- synchronize speedspacechart project with npm deployment specifications - add a readMe file - create SpeedSpaceChart main component - add a story for storyBook using sampleData.ts - create useCanvas custom hook in hooks.ts - create layers in components/layers/ - create /components/helpers/ with drawElements/ containing draw functions files, one for each king of element - create layersManager for interactive functions as zoom and reset - add X axis zoom - create details box following the reticle - add snapping to closest pr - extract tain details box from reticle draw function to his own component - adapt vertical lines to PRs position - add PRs names - add tests for utils functions
64929ac
to
ce92e48
Compare
No description provided.