Fix speed space chart round value to decimal #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flomonster
force-pushed
the
fam/fix-speed-space-chart-reticle
branch
from
21b993d to
d784c1c
Compare
Yohh
reviewed
Sep 4, 2024
There was a problem hiding this comment.
thanks for this PR
ok for the rounded adjustment
OpenRailAssociation/osrd#8297 can't be closed, .0 is still possible, we should add a condition to avoid toFixed() method if roundedPosition doesn't have a decimal
Good point, I also fixed it (in a second commit). Important This fix expose a new bug. The reticle is slightly offset from the graduations.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the rounding to decimal instead of unit.
close OpenRailAssociation/osrd#8297