Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring speed space chart tick X axis #436

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Code refactoring speed space chart tick X axis #436

merged 2 commits into from
Sep 10, 2024

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Sep 6, 2024 •
edited
Loading

Main changes :

  1. MaxPositionValues function rationalized.
  2. Iterate on ticks instead of position in speeds.
  3. Modify the way we handle scaling.

This corrects a few problems:

  • X axis of ticks no longer disappears when zoomed in.
  • Tick position is more accurate
  • Having a simplified version of speeds doesn't break everything.

@flomonster flomonster marked this pull request as ready for review September 6, 2024 13:30
@flomonster flomonster requested a review from a team as a code owner September 6, 2024 13:31
@flomonster flomonster force-pushed the fam/speedspacechart-refacto-tickX branch 2 times, most recently from dc11984 to f695b9f Compare September 6, 2024 16:03
Base automatically changed from fam/cleanup-speed-space-chart-is-eco to dev September 6, 2024 16:06
@flomonster flomonster force-pushed the fam/speedspacechart-refacto-tickX branch from f695b9f to f4adbce Compare September 6, 2024 16:10
Yohh
Yohh reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks for this great refacto!

a few comments to clarify some nebulous parts

@flomonster flomonster requested review from kmer2016 and removed request for achrafmohye September 10, 2024 08:04
@flomonster flomonster mentioned this pull request Sep 10, 2024
Closed
@flomonster flomonster force-pushed the fam/speedspacechart-refacto-tickX branch 2 times, most recently from 86c5b4a to f8e28b7 Compare September 10, 2024 08:58
@flomonster flomonster requested a review from Yohh September 10, 2024 08:58
@flomonster flomonster force-pushed the fam/speedspacechart-refacto-tickX branch from f8e28b7 to c27a72a Compare September 10, 2024 09:00
Yohh
Yohh approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SharglutDev
SharglutDev approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, great job !

@flomonster flomonster force-pushed the fam/speedspacechart-refacto-tickX branch from 9e9158f to 7153940 Compare September 10, 2024 18:06
@flomonster flomonster added this pull request to the merge queue Sep 10, 2024
Merged via the queue into dev with commit 6dde153 Sep 10, 2024
5 checks passed
@flomonster flomonster deleted the fam/speedspacechart-refacto-tickX branch September 10, 2024 18:11
@flomonster flomonster self-assigned this Sep 12, 2024
@Castavo Castavo mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yohh Yohh Yohh approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

@kmer2016 kmer2016 Awaiting requested review from kmer2016

Assignees

@flomonster flomonster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flomonster @Yohh @SharglutDev