Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring speed space chart tick Y axis #450

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Sep 10, 2024

Main changes :

  1. Iterate on ticks instead of position in speeds.
  2. The scale is adapting with the max speed of the chart

This corrects a few problems:

  • Axis Y is not visually overloaded even with a top speed of 300km/h
  • The Y axis is not visually empty even with a maximum speed of 30km/h
  • Having a simplified version of speeds doesn't break everything.

Before

image

After

image

@flomonster flomonster force-pushed the fam/speedspacechart-refacto-tickY branch from c248b70 to 1ac216a Compare September 10, 2024 10:26
@flomonster flomonster requested a review from Yohh September 10, 2024 10:26
@flomonster flomonster changed the base branch from dev to fam/speedspacechart-refacto-tickX September 10, 2024 10:26
@flomonster flomonster requested a review from Math-R September 10, 2024 10:27
@flomonster flomonster marked this pull request as ready for review September 10, 2024 10:36
@flomonster flomonster requested a review from a team as a code owner September 10, 2024 10:36
@flomonster flomonster force-pushed the fam/speedspacechart-refacto-tickY branch from 1ac216a to 394a522 Compare September 10, 2024 10:38
@flomonster flomonster force-pushed the fam/speedspacechart-refacto-tickX branch from 9e9158f to 7153940 Compare September 10, 2024 18:06
Base automatically changed from fam/speedspacechart-refacto-tickX to dev September 10, 2024 18:11
@flomonster flomonster force-pushed the fam/speedspacechart-refacto-tickY branch from 394a522 to 171a65f Compare September 10, 2024 18:12
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm skeptical about removing major lines, the mockup clearly shows them, the only difference is about the max speed to display
Capture d’écran 2024-09-11 à 06 37 29
did you talk about it with Thibaut?

and if we keep this change, drawMajorGridY() should become drawGridY()

@flomonster
Copy link
Contributor Author

I'm skeptical about removing major lines, the mockup clearly shows them, the only difference is about the max speed to display

I misinterpreted the mock-up. I'll put the major lines back.

@flomonster flomonster self-assigned this Sep 12, 2024
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, left a few comments

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, nice improvement !

@flomonster flomonster force-pushed the fam/speedspacechart-refacto-tickY branch from 8aa5df0 to c8c923f Compare September 13, 2024 08:32
@flomonster flomonster added this pull request to the merge queue Sep 13, 2024
Merged via the queue into dev with commit cc77094 Sep 13, 2024
6 checks passed
@flomonster flomonster deleted the fam/speedspacechart-refacto-tickY branch September 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants