-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactoring speed space chart tick Y axis #450
Conversation
c248b70
to
1ac216a
Compare
1ac216a
to
394a522
Compare
9e9158f
to
7153940
Compare
394a522
to
171a65f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misinterpreted the mock-up. I'll put the major lines back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, left a few comments
ui-speedspacechart/src/components/helpers/drawElements/tickY.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/tickY.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/tickY.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/gridY.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
ui-speedspacechart/src/components/helpers/drawElements/tickY.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, nice improvement !
ui-speedspacechart/src/components/helpers/drawElements/tickY.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Amsallem <[email protected]>
Signed-off-by: Florian Amsallem <[email protected]>
8aa5df0
to
c8c923f
Compare
Main changes :
speeds
.This corrects a few problems:
speeds
doesn't break everything.Before
After