Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor InputWithSuggestions to ComboBox #456

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Refactor InputWithSuggestions to ComboBox #456

merged 1 commit into from
Sep 18, 2024

Conversation

achrafmohye
Copy link
Contributor

@achrafmohye achrafmohye commented Sep 11, 2024 •
edited
Loading

Closes #423

@achrafmohye achrafmohye requested a review from a team as a code owner September 11, 2024 08:54
@achrafmohye achrafmohye force-pushed the ame/refactor-inputwithsuggestions-to-combobox branch from 0732eae to 47d292e Compare September 11, 2024 08:55
SharglutDev
SharglutDev reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, left some comments

SharglutDev
SharglutDev approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job :)

RomainValls
RomainValls approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@achrafmohye achrafmohye force-pushed the ame/refactor-inputwithsuggestions-to-combobox branch 2 times, most recently from 876dcd1 to 3ef080f Compare September 17, 2024 09:15
@achrafmohye achrafmohye force-pushed the ame/refactor-inputwithsuggestions-to-combobox branch from 3ef080f to 1b55ecd Compare September 17, 2024 10:25
@achrafmohye
ui-core: refactor InputWithSuggestions to ComboBox and improve compon…
5efb1cc 
…ent logic

Signed-off-by: Achraf Mohyeddine <[email protected]>

Signed-off-by: Achraf Mohyeddine <[email protected]>
@achrafmohye achrafmohye force-pushed the ame/refactor-inputwithsuggestions-to-combobox branch from 1b55ecd to 5efb1cc Compare September 18, 2024 09:33
@achrafmohye achrafmohye added this pull request to the merge queue Sep 18, 2024
kmer2016
kmer2016 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Merged via the queue into dev with commit 5251ba8 Sep 18, 2024
6 checks passed
@achrafmohye achrafmohye deleted the ame/refactor-inputwithsuggestions-to-combobox branch September 18, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmer2016 kmer2016 kmer2016 approved these changes

@RomainValls RomainValls RomainValls approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptation InputWithSuggestions to accept result coming from the api
4 participants
@achrafmohye @kmer2016 @RomainValls @SharglutDev