Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance TimePicker to increment and decrement hours at minutes boundaries #498

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Enhance TimePicker to increment and decrement hours at minutes boundaries #498

merged 1 commit into from
Sep 18, 2024

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 requested a review from a team as a code owner September 17, 2024 15:43
@kmer2016 kmer2016 force-pushed the cnh/increment-decrement-minutes branch from 1bcbbdc to 9e6c6fe Compare September 17, 2024 15:45
@kmer2016 kmer2016 changed the title ui-core, TimePicker: Enhance TimePicker to increment and decrement hours at minutes boundaries Enhance TimePicker to increment and decrement hours at minutes boundaries Sep 17, 2024
@kmer2016 kmer2016 force-pushed the cnh/increment-decrement-minutes branch 3 times, most recently from c84edef to dca4ea2 Compare September 17, 2024 16:13
SharglutDev
SharglutDev requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix ! It works great except when I decrement when on 00h00, it goes to 00h59 instead of 23h59.

@kmer2016 kmer2016 force-pushed the cnh/increment-decrement-minutes branch from dca4ea2 to 668919d Compare September 18, 2024 08:48
SharglutDev
SharglutDev approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested :)

@kmer2016 kmer2016 added this pull request to the merge queue Sep 18, 2024
Merged via the queue into dev with commit d8983fc Sep 18, 2024
6 checks passed
@kmer2016 kmer2016 deleted the cnh/increment-decrement-minutes branch September 18, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time picker can't set +/-1mn if it changes the hour
2 participants
@kmer2016 @SharglutDev