Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-core: timepicker handles seconds #558

Merged
merged 1 commit into from
Dec 12, 2024
Merged

ui-core: timepicker handles seconds #558

merged 1 commit into from
Dec 12, 2024

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Sep 26, 2024 •
edited by clarani
Loading

closes #602

@anisometropie anisometropie changed the title s time picker Sep 26, 2024
@anisometropie anisometropie force-pushed the vcs/time-picker branch 3 times, most recently from 9cf9f9f to 9f1147d Compare October 1, 2024 07:55
@anisometropie anisometropie marked this pull request as ready for review October 1, 2024 08:00
@anisometropie anisometropie requested a review from a team as a code owner October 1, 2024 08:00
clarani
clarani requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a problem on the css
image

SarahBellaha
SarahBellaha approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a tiny suggestion. Works great, lgtm :)

@anisometropie anisometropie force-pushed the vcs/time-picker branch 2 times, most recently from 4e8251c to bf0b141 Compare October 3, 2024 16:35
kmer2016
kmer2016 reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! just a small suggestion

@anisometropie anisometropie requested a review from clarani October 4, 2024 07:56
@anisometropie
Copy link
Contributor Author

After discussion with @thibautsailly, issues with AM/PM is not a priority, considering virtually none of our users are from region using AM/PM

@anisometropie anisometropie force-pushed the vcs/time-picker branch 2 times, most recently from e273552 to 6ac108f Compare December 5, 2024 12:46
@emersion emersion changed the title time picker ui-core: timepicker handles seconds Dec 5, 2024
clarani
clarani approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@anisometropie anisometropie added this pull request to the merge queue Dec 12, 2024
Merged via the queue into dev with commit a275fc7 Dec 12, 2024
6 checks passed
@anisometropie anisometropie deleted the vcs/time-picker branch December 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmer2016 kmer2016 kmer2016 approved these changes

@clarani clarani clarani approved these changes

@SarahBellaha SarahBellaha SarahBellaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timepicker: handle seconds
4 participants
@anisometropie @kmer2016 @clarani @SarahBellaha