Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cnh/UI core/fix some styles #62

Merged
merged 1 commit into from
May 16, 2024
Merged

Cnh/UI core/fix some styles #62

merged 1 commit into from
May 16, 2024

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented May 15, 2024

  • Improve responsiveness by removing fixed width on :
    • Select
    • Input
    • Textarea
    • tokenInput
    • radioButton
  • remove children from mandatory props on :
    • Select
    • Textarea
  • Expose component props type [UI-CORE] #63
  • Change style of input when focus

@kmer2016 kmer2016 requested review from nicolaswurtz and clarani May 15, 2024 10:07
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ not tested though

@kmer2016 kmer2016 force-pushed the cnh/ui-core/fix-some-styles branch from 95f86e3 to ca5d630 Compare May 16, 2024 09:10
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM, not tested

ui-core, select: Update Select component props to exclude children from FieldWrapperProps and styles to improve responsiveness

ui-core, textarea: Update TextArea component to exclude children from FieldWrapperProps and improve responsiveness

ui-core, tokenInput: Add decorator to TokenInput story for better display in Storybook

ui-core, radiobutton: remove unnecessary CSS code for radio button wrapper

ui-core : export component props type

ui-core, input : prevent trailing content from going to 2 lines on firefox

ui-core: change focus input style
@kmer2016 kmer2016 force-pushed the cnh/ui-core/fix-some-styles branch from ca5d630 to d0cf0a6 Compare May 16, 2024 14:34
@kmer2016 kmer2016 merged commit 8296314 into dev May 16, 2024
1 check passed
@kmer2016 kmer2016 deleted the cnh/ui-core/fix-some-styles branch May 16, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants