ui-manchette-with-spacetimechart: fix spacetimechart scaling if hidde… #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SharglutDev
force-pushed
the
ui-manchette-with-spacetimechart/fix-spacetimechart-scaling
branch
4 times, most recently
from
0f0770f to
45a1ad5
Compare
When the first waypoint or first x waypoints were hidden, the space time chart wouldn't display the corresponding curve in linear mode Signed-off-by: SharglutDev <[email protected]>
clarani
reviewed
Oct 9, 2024
In linear mode, the space time chart didn't shrink when there was some waypoints hidden in the middle of the path Signed-off-by: SharglutDev <[email protected]>
SharglutDev
force-pushed
the
ui-manchette-with-spacetimechart/fix-spacetimechart-scaling
branch
from
45a1ad5 to
a0d0305
Compare
SharglutDev
deleted the
ui-manchette-with-spacetimechart/fix-spacetimechart-scaling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n waypoints
Fix an issue where the space time chart wouldn't correspond to the manchette in linear mode when a bunch of waypoints were hidden in the middle of the path
Fix an issue where the space time chart wouldn't correspond to the manchette when the first x waypoints were hidden
Important
To test these changes, you need to be able to launch osrd-ui inside osrd and be on this PR (to hide waypoints on the manchette)