Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-spacetimechart: add missing ConflictLayer export #624

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

emersion
Copy link
Member

@emersion emersion commented Oct 8, 2024

We're not able to use the component from outside if it's not exported in index.ts.

Oversight on my end, sorry!

We're not able to use the component from outside if it's not
exported in index.ts.

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion requested a review from a team as a code owner October 8, 2024 13:45
@emersion emersion self-assigned this Oct 8, 2024
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@emersion emersion added this pull request to the merge queue Oct 8, 2024
Merged via the queue into dev with commit c70d4b2 Oct 8, 2024
6 checks passed
@emersion emersion deleted the emr/conflict-layer-export branch October 8, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants