Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: input and combo box text overflow fix #629

Merged
merged 1 commit into from
Oct 17, 2024
Merged

front: input and combo box text overflow fix #629

merged 1 commit into from
Oct 17, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Oct 10, 2024 •
edited
Loading

part of #596

Fix Input overflow with icons
Capture d’écran 2024-10-17 à 09 33 09

Fix ComboBox (that use Input)
Capture d’écran 2024-10-10 à 10 55 50

@Wadjetz Wadjetz self-assigned this Oct 10, 2024
@Wadjetz Wadjetz requested a review from a team as a code owner October 10, 2024 08:56
@Wadjetz Wadjetz requested a review from kmer2016 October 10, 2024 08:58
@Wadjetz Wadjetz force-pushed the ebe/input-combo-box-text-overflow branch from e270632 to 3c5a996 Compare October 10, 2024 09:00
SharglutDev
SharglutDev approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job ! Left just one comment, you can fix it and merge :)

@Wadjetz Wadjetz force-pushed the ebe/input-combo-box-text-overflow branch from 3c5a996 to cd3c338 Compare October 17, 2024 07:30
@Wadjetz Wadjetz added this pull request to the merge queue Oct 17, 2024
Merged via the queue into dev with commit 9949bbf Oct 17, 2024
6 checks passed
@Wadjetz Wadjetz deleted the ebe/input-combo-box-text-overflow branch October 17, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@kmer2016 kmer2016 Awaiting requested review from kmer2016

@achrafmohye achrafmohye Awaiting requested review from achrafmohye

@clarani clarani Awaiting requested review from clarani

Assignees

@Wadjetz Wadjetz

Labels
area:front
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wadjetz @SharglutDev