ui-spacetimechart: use paths layer for conflicts #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/time-caption-above
branch
from
9e51598 to
9fdafcb
Compare
SharglutDev
reviewed
Oct 17, 2024
|
I still have the issue too :/ |
The overlay layer is rendered on top of the captions, which is undesirable here. Signed-off-by: Simon Ser <[email protected]>
|
Apologies, I messed up when testing. I've updated the PR. Here's a hack patch to test this in the storybook: diff --git a/ui-spacetimechart/src/stories/layers.stories.tsx b/ui-spacetimechart/src/stories/layers.stories.tsx
index 028ee5b5f118..2c6479c0f5d3 100644
--- a/ui-spacetimechart/src/stories/layers.stories.tsx
+++ b/ui-spacetimechart/src/stories/layers.stories.tsx
@@ -32,7 +32,7 @@ const CONFLICTS = [
timeStart: +START_DATE + 35 * MINUTE,
timeEnd: +START_DATE + 37 * MINUTE,
spaceStart: 39 * KILOMETER,
- spaceEnd: 41 * KILOMETER,
+ spaceEnd: 99999 * KILOMETER,
},
];
|
emersion
force-pushed
the
emr/time-caption-above
branch
from
9fdafcb to
7ffc56c
Compare
emersion
changed the title
SharglutDev
approved these changes
Oct 21, 2024
|
That one uses the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overlay layer is rendered on top of the captions, which is undesirable here.
Example bug: