Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-manchette: add fit button #649

Merged
merged 2 commits into from
Oct 23, 2024
Merged

ui-manchette: add fit button #649

merged 2 commits into from
Oct 23, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 17, 2024

closes #410

image

@clarani clarani requested a review from a team as a code owner October 17, 2024 14:20
@clarani clarani force-pushed the cni/410-add-fit-button branch 2 times, most recently from 97855db to eb6228d Compare October 17, 2024 14:34
@clarani clarani requested review from Math-R, theocrsb, Yohh and emersion and removed request for theocrsb and Math-R October 18, 2024 11:50
@clarani clarani force-pushed the cni/410-add-fit-button branch from b1ccfae to 65c9076 Compare October 18, 2024 13:47
@clarani clarani force-pushed the cni/410-add-fit-button branch from 65c9076 to 974672d Compare October 22, 2024 08:55
@clarani clarani force-pushed the cni/410-add-fit-button branch from 974672d to ec984f0 Compare October 22, 2024 12:12
@emersion
Copy link
Member

Seems like the first commit "ui-manchette: clean manchette's story" is just shuffling stuff around now? Maybe it should be dropped?

@clarani clarani force-pushed the cni/410-add-fit-button branch from ec984f0 to 5ee4d9f Compare October 23, 2024 07:16
@clarani
Copy link
Contributor Author

clarani commented Oct 23, 2024

You're right, it's done :)

@clarani clarani enabled auto-merge October 23, 2024 07:16
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@clarani clarani added this pull request to the merge queue Oct 23, 2024
Merged via the queue into dev with commit db67b55 Oct 23, 2024
6 checks passed
@clarani clarani deleted the cni/410-add-fit-button branch October 23, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manchette: add fit button
3 participants