-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui-speedspacechart: add power restrictions layer #73
Merged
SharglutDev
merged 1 commit into
dev
from
pfn/ui-speedspacechart/add-power-restrictions-layer
Jul 10, 2024
Merged
ui-speedspacechart: add power restrictions layer #73
SharglutDev
merged 1 commit into
dev
from
pfn/ui-speedspacechart/add-power-restrictions-layer
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee6260a
to
3d4a99d
Compare
cb9b35e
to
184ec4f
Compare
a5750b6
to
785495c
Compare
emersion
reviewed
Jul 8, 2024
ui-speedspacechart/src/components/helpers/drawElements/electricalProfile.ts
Show resolved
Hide resolved
emersion
reviewed
Jul 8, 2024
emersion
reviewed
Jul 8, 2024
emersion
reviewed
Jul 8, 2024
ui-speedspacechart/src/components/helpers/drawElements/reticle.ts
Outdated
Show resolved
Hide resolved
emersion
reviewed
Jul 8, 2024
ui-speedspacechart/src/components/helpers/drawElements/powerRestrictions.ts
Show resolved
Hide resolved
emersion
reviewed
Jul 8, 2024
ui-speedspacechart/src/components/helpers/drawElements/powerRestrictions.ts
Outdated
Show resolved
Hide resolved
d479de5
to
1bb6b32
Compare
jacomyal
requested changes
Jul 9, 2024
emersion
reviewed
Jul 9, 2024
LGTM - and great work, by the way 👍 |
jacomyal
approved these changes
Jul 9, 2024
emersion
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work! The textBaseline
thing is optional :)
kmer2016
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
f622267
to
17389f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #74