Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-speedspacechart: add power restrictions layer #73

Merged

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Jun 20, 2024

close #74

@SharglutDev SharglutDev force-pushed the pfn/ui-speedspacechart/add-power-restrictions-layer branch 4 times, most recently from ee6260a to 3d4a99d Compare June 26, 2024 15:01
@SharglutDev SharglutDev force-pushed the pfn/ui-speedspacechart/add-power-restrictions-layer branch 4 times, most recently from cb9b35e to 184ec4f Compare July 4, 2024 14:08
@SharglutDev SharglutDev marked this pull request as ready for review July 5, 2024 10:51
@SharglutDev SharglutDev force-pushed the pfn/ui-speedspacechart/add-power-restrictions-layer branch from a5750b6 to 785495c Compare July 5, 2024 15:05
@SharglutDev SharglutDev force-pushed the pfn/ui-speedspacechart/add-power-restrictions-layer branch from d479de5 to 1bb6b32 Compare July 9, 2024 07:38
@SharglutDev SharglutDev requested review from jacomyal and emersion July 9, 2024 13:37
@jacomyal
Copy link
Contributor

jacomyal commented Jul 9, 2024

LGTM - and great work, by the way 👍

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! The textBaseline thing is optional :)

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SharglutDev SharglutDev force-pushed the pfn/ui-speedspacechart/add-power-restrictions-layer branch from f622267 to 17389f2 Compare July 10, 2024 06:17
@SharglutDev SharglutDev merged commit 538cf25 into dev Jul 10, 2024
1 check passed
@SharglutDev SharglutDev deleted the pfn/ui-speedspacechart/add-power-restrictions-layer branch July 10, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osrd-ui: add power restrictions layer in GEV V2
4 participants