-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slider + spacetime #756
slider + spacetime #756
Conversation
9ea0962
to
6c23aee
Compare
00ba749
to
9fb2c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested 👍
dea47ce
to
4532013
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch, the storybook example works very well and the consts + exponential math stuff is easy to follow!
ui-manchette-with-spacetimechart/src/hooks/useManchetteWithSpaceTimeChart.ts
Show resolved
Hide resolved
e65d3a2
to
0a9ec78
Compare
0a9ec78
to
18e0099
Compare
Signed-off-by: Valentin Chanas <[email protected]>
Signed-off-by: Valentin Chanas <[email protected]>
…roll sliding Signed-off-by: Valentin Chanas <[email protected]>
18e0099
to
292c250
Compare
ui-manchette-with-spacetimechart/src/hooks/useManchetteWithSpaceTimeChart.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Valentin Chanas <[email protected]>
b955c8b
to
f557142
Compare
Behavior for OpenRailAssociation/osrd#9723
main ticket https://github.com/osrd-project/osrd-confidential/issues/869
closes #756