Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slider + spacetime #756

Merged
merged 4 commits into from
Dec 20, 2024
Merged

slider + spacetime #756

merged 4 commits into from
Dec 20, 2024

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Dec 10, 2024

  • new space time story with slider zoom
  • adapt useManchetteWithSpaceTime hook to work with slider zoom and mouse scroll zoom

Behavior for OpenRailAssociation/osrd#9723

main ticket https://github.com/osrd-project/osrd-confidential/issues/869

closes #756

@anisometropie anisometropie force-pushed the vcs/space-time-h-zoom branch 5 times, most recently from 9ea0962 to 6c23aee Compare December 12, 2024 12:27
@anisometropie anisometropie marked this pull request as ready for review December 12, 2024 12:27
@anisometropie anisometropie requested a review from a team as a code owner December 12, 2024 12:27
@anisometropie anisometropie force-pushed the vcs/space-time-h-zoom branch 3 times, most recently from 00ba749 to 9fb2c41 Compare December 12, 2024 12:58
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested 👍

@anisometropie anisometropie force-pushed the vcs/space-time-h-zoom branch 4 times, most recently from dea47ce to 4532013 Compare December 18, 2024 12:27
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, the storybook example works very well and the consts + exponential math stuff is easy to follow!

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anisometropie anisometropie added this pull request to the merge queue Dec 20, 2024
@anisometropie anisometropie removed this pull request from the merge queue due to a manual request Dec 20, 2024
@anisometropie anisometropie added this pull request to the merge queue Dec 20, 2024
Merged via the queue into dev with commit 7d39639 Dec 20, 2024
6 checks passed
@anisometropie anisometropie deleted the vcs/space-time-h-zoom branch December 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants