ui-speedspacechart : add speed limit tags layer #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caracol3
force-pushed
the
mcy/ui-speedspacechart/add-speed-limit-tags-layer
branch
from
2eeccf8 to
1417f9d
Compare
theocrsb
reviewed
Jul 9, 2024
Caracol3
force-pushed
the
mcy/ui-speedspacechart/add-speed-limit-tags-layer
branch
from
9a512a5 to
42e3e48
Compare
Caracol3
force-pushed
the
mcy/ui-speedspacechart/add-speed-limit-tags-layer
branch
from
dd1c3ee to
ed2d8d6
Compare
clarani
reviewed
Jul 11, 2024
Caracol3
force-pushed
the
mcy/ui-speedspacechart/add-speed-limit-tags-layer
branch
from
b5b6ae6 to
731e3bc
Compare
Math-R
reviewed
Jul 11, 2024
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
Caracol3
force-pushed
the
mcy/ui-speedspacechart/add-speed-limit-tags-layer
branch
from
bd95633 to
b0a8c89
Compare
SharglutDev
requested changes
Jul 11, 2024
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
SharglutDev
requested changes
Jul 12, 2024
ui-speedspacechart/src/components/helpers/drawElements/speedLimitTags.ts
Outdated
Show resolved
Hide resolved
Caracol3
force-pushed
the
mcy/ui-speedspacechart/add-speed-limit-tags-layer
branch
from
7591fee to
7972dbe
Compare
SharglutDev
approved these changes
Jul 12, 2024
- adding fake data for speed limit tags visualisation - add drawSvgImageWithColor, LoadSvgImage and drawRoundRect in utils.ts - adding raw.d.ts to allow raw svg import - adding createSvgBlobUrl to convert svg to string - changed the logic for calculating the linear width - repositioned the linear within the canvas - adding the tooltip above incompatible speed limit tag - modify drawSeparatorLinearLayer to fix the missing separator problem - adding colorDictionary - adding new const after refactorisation
Caracol3
force-pushed
the
mcy/ui-speedspacechart/add-speed-limit-tags-layer
branch
from
7972dbe to
f484e9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close OpenRailAssociation/osrd#7732