Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-core: add narrow input style #813

Merged
merged 2 commits into from
Jan 23, 2025
Merged

ui-core: add narrow input style #813

merged 2 commits into from
Jan 23, 2025

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Jan 13, 2025 •
edited
Loading

close #821

@SharglutDev SharglutDev force-pushed the ui-core/add-narrow-input-style branch from 96cbb2f to 834582d Compare January 14, 2025 13:17
@SharglutDev SharglutDev marked this pull request as ready for review January 14, 2025 13:21
@SharglutDev SharglutDev requested a review from a team as a code owner January 14, 2025 13:21
SarahBellaha
SarahBellaha approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SharglutDev
Copy link
Contributor Author

@SarahBellaha @emersion, I added another commit for Sarah's request to prevent having required and narrow defined at the same time. You can test it by trying to set both props at true in any component calling Input component. Type is a bit messy but it works. What do you think ? Do we keep it or no ?

@emersion emersion changed the title ui-core/add narrow input style ui-core: add narrow input style Jan 22, 2025
@emersion emersion self-requested a review January 23, 2025 11:30
@SharglutDev
ui-core: adapt tooltip position
844fcd7 
Change the element receiving the relative position in order to improve scalability for positioning elements relative to it.

Signed-off-by: SharglutDev <[email protected]>
@SharglutDev SharglutDev force-pushed the ui-core/add-narrow-input-style branch from a472cf6 to fe2e70c Compare January 23, 2025 14:06
@SharglutDev
Copy link
Contributor Author

After discussions, removed the commit for type safety with required/narrow. Instead, throw an error if both are true at the same time.

@SharglutDev
ui-core: add narrow input style
89c7e12 
This new style can be used for narrow forms like stdcm.
Add tooltip by default in statusWithMessage if narrow is present.
Throw an error if narrow and required are true at the same time.

Signed-off-by: SharglutDev <[email protected]>
@SharglutDev SharglutDev force-pushed the ui-core/add-narrow-input-style branch from fe2e70c to 89c7e12 Compare January 23, 2025 14:20
@SharglutDev SharglutDev enabled auto-merge January 23, 2025 14:20
@SharglutDev SharglutDev added this pull request to the merge queue Jan 23, 2025
Merged via the queue into dev with commit 2bda78d Jan 23, 2025
6 checks passed
@SharglutDev SharglutDev deleted the ui-core/add-narrow-input-style branch January 23, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

@SarahBellaha SarahBellaha SarahBellaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add narrow input style
3 participants
@SharglutDev @emersion @SarahBellaha