Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-core: fix circular dependency in tolerance picker #822

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

emersion
Copy link
Member

Fix the following warning by moving a constant in a shared file:

(!) Circular dependency
src/components/inputs/tolerancePicker/TolerancePicker.tsx -> src/components/inputs/tolerancePicker/ToleranceRangeGrid.tsx -> src/components/inputs/tolerancePicker/TolerancePicker.tsx

Fix the following warning by moving a constant in a shared file:

    (!) Circular dependency
    src/components/inputs/tolerancePicker/TolerancePicker.tsx -> src/components/inputs/tolerancePicker/ToleranceRangeGrid.tsx -> src/components/inputs/tolerancePicker/TolerancePicker.tsx

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion requested a review from a team as a code owner January 14, 2025 09:09
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emersion emersion added this pull request to the merge queue Jan 14, 2025
Merged via the queue into dev with commit 52af6eb Jan 14, 2025
6 checks passed
@emersion emersion deleted the emr/tolerance-picker-circular-dep branch January 14, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants