Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-manchette-with-spacetimechart: fix the color and level of the path #830

Merged
merged 1 commit into from
Jan 22, 2025
Merged

ui-manchette-with-spacetimechart: fix the color and level of the path #830

merged 1 commit into from
Jan 22, 2025

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Jan 20, 2025

close #828

@Math-R Math-R requested a review from a team as a code owner January 20, 2025 10:42
theocrsb
theocrsb reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the impression that the selected train doesn't have a width of 1.5px
image

@Math-R
Copy link
Contributor Author

Math-R commented Jan 20, 2025

I have the impression that the selected train doesn't have a width of 1.5px image

In storybook, try it in the default tab of ManchetteWithSpaceTimeChart

@Math-R Math-R assigned Math-R and unassigned theocrsb and SharglutDev Jan 20, 2025
theocrsb
theocrsb approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested !

SharglutDev
SharglutDev approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested (just some import order warnings)

@Math-R Math-R force-pushed the mrd/fix-selected-train-color branch from 5787be2 to d1ed0e4 Compare January 22, 2025 13:20
@Math-R Math-R enabled auto-merge January 22, 2025 13:20
@Math-R
ui-manchette-with-spacetimechart: fix the color and level of the path…
6fa01a9 
… relative to the selected train

Signed-off-by: Math_R_ <[email protected]>
@Math-R Math-R force-pushed the mrd/fix-selected-train-color branch from d1ed0e4 to 6fa01a9 Compare January 22, 2025 14:12
@Math-R Math-R added this pull request to the merge queue Jan 22, 2025
Merged via the queue into dev with commit 67f353e Jan 22, 2025
6 checks passed
@Math-R Math-R deleted the mrd/fix-selected-train-color branch January 22, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theocrsb theocrsb theocrsb approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees

@Math-R Math-R

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix selected path color in usePath
3 participants
@Math-R @theocrsb @SharglutDev