Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path label positioning in spacetimechart #838

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Jan 20, 2025

Close #468
Close #529

@Synar Synar requested a review from a team as a code owner January 20, 2025 17:59
@Synar Synar force-pushed the ali/fix-path-label-positioning-in-speedspacechart branch from 9076c1e to dc4ccb7 Compare January 20, 2025 18:03
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you just rename your commits ? You're fixing the spacetimechart, and not the speedspacechart ;)

@Synar
Copy link
Contributor Author

Synar commented Jan 21, 2025

Oops, will fix! '^^

@Synar Synar changed the title fix path label positioning in speedspacechart fix path label positioning in spqcetimechart Jan 21, 2025
@Synar Synar changed the title fix path label positioning in spqcetimechart fix path label positioning in spacetimechart Jan 21, 2025
@Synar Synar force-pushed the ali/fix-path-label-positioning-in-speedspacechart branch from dc4ccb7 to 084da0c Compare January 21, 2025 17:12
@Synar Synar enabled auto-merge January 21, 2025 17:13
@Synar Synar added this pull request to the merge queue Jan 21, 2025
Merged via the queue into dev with commit 8840979 Jan 21, 2025
6 checks passed
@Synar Synar deleted the ali/fix-path-label-positioning-in-speedspacechart branch January 21, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants