ui-manchette, ui-trackoccupancydiagram: add missing ui-core dependency #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ui-core's stylesheet is already included from ui-manchette/src/index.ts. Signed-off-by: Simon Ser <[email protected]>
ui-core is used from these components, but is missing from dependencies. This makes the lerna build fail. Signed-off-by: Simon Ser <[email protected]>
clarani
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui-core is used from these components, but is missing from dependencies. This makes the lerna build fail.
(Also a small cleanup for a duplicate CSS import.)
Test:
npm run clean && npx lerna run build.I've looked at all imports with these commands: