ui-spacetimechart: fix blank stories #858
Merged
+37
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/spacetimechart-sizing
branch
from
40c8160 to
9aff6b7
Compare
The space time chart stories were sometimes not loading properly, showing a blank page. Two issues: - All stories were passing className='absolute inset-0' to SpaceTimeChart. However, SpaceTimeChart was combining these classes with 'relative'. As a result, the browser would roll a dice and pick either 'absolute' or 'relative'. When 'relative' is picked first, 'inset-0' has no effect because… - All stories except one were using a wrapper div with className="inset-0". This had no effect because this div is neither absolute nor relative. As a result, half the time the chart would have a zero height. Fix this by: - Adding absolute positioning to the wrapper div. - Setting the height of the SpaceTimeChart instead of mixing up conflicting positioning classes. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/spacetimechart-sizing
branch
from
9aff6b7 to
a612c9d
Compare
Synar
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Overall LGTM. This bug was extremely annoying when working on the component, so thanks a lot!
Tangent to this PR, but in the osrd repo we also use <className="inset-0 absolute h-full">, should we remove the absolute and inset-0?
More generally there seem to be a lot of conflicting positioning class uses in this component and its wrappers, which could use a cleanup.
Yes, I think so. We specify a fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The space time chart stories were sometimes not loading properly, showing a blank page.
Two issues:
As a result, half the time the chart would have a zero height.
Fix this by: