Slider fixes #868
Merged
Slider fixes #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anisometropie
force-pushed
the
vcs/minor-slider-fixes
branch
2 times, most recently
from
56dfe4c to
e1bbf96
Compare
Signed-off-by: Valentin Chanas <[email protected]>
Signed-off-by: Valentin Chanas <[email protected]>
anisometropie
force-pushed
the
vcs/minor-slider-fixes
branch
from
13b21bd to
e138a2d
Compare
anisometropie
requested review from
Yohh,
SharglutDev and
Castavo
and removed request for
Yohh
SharglutDev
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Lgtm and tested, good job ! You can resolve the last comment after fixing it.
There is just one weird behavior (not related to this PR), maybe we can discuss it with @thibautsailly : when dragging the slider with the mouse, as the thumb is smaller, I can never reach the beginning/end of the range track
Signed-off-by: Valentin Chanas <[email protected]>
anisometropie
force-pushed
the
vcs/minor-slider-fixes
branch
from
e138a2d to
c3df605
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix committed value
closes OpenRailAssociation/osrd#10598
left/right styling
closes OpenRailAssociation/osrd#10599
rest https://www.sketch.com/s/ca1f66cf-046d-4992-ae63-62187269ba7e/v/mGRKq9/a/0A3RkWj#Inspect
active https://www.sketch.com/s/ca1f66cf-046d-4992-ae63-62187269ba7e/v/mGRKq9/a/oMmnEJj#Inspect
focus (using tab) https://www.sketch.com/s/ca1f66cf-046d-4992-ae63-62187269ba7e/v/mGRKq9/a/lReWJEv#Inspect
hover https://www.sketch.com/s/ca1f66cf-046d-4992-ae63-62187269ba7e/v/mGRKq9/a/kK4bZjD#Inspect
firefox insanity (committed value off by 1)
OpenRailAssociation/osrd#9722 (comment)
#closes OpenRailAssociation/osrd#10621